Skip to content

WIP: edited content for plug-in components #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

WIP: edited content for plug-in components #47

wants to merge 1 commit into from

Conversation

jc-berger
Copy link
Contributor

This PR is for issue #258: adding plugin components.

This first commit is only doc edits. I'll need developer insight if we need to fix the code snippets and source yaml to reflect that plug-ins are now specified using devfiles.

Also, I notice the {prod-short} populates Devfiles. To my knowledge, we don't capitalize devfiles unless it begins a sentence. I wanted confirmation before changing it.

@jc-berger jc-berger added the documentation Improvements or additions to documentation label Mar 29, 2021
@jc-berger jc-berger self-assigned this Mar 29, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jc-berger

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

@jc-berger: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnmcollier
Copy link
Member

I don't know if we need this doc anymore, we're removing plugins from the devfile spec with devfile/api#333

Maybe it'll be better to remove this doc once devfile/api#333 is merged?

CC @davidfestal

@elsony
Copy link
Contributor

elsony commented Apr 6, 2021

+1 we should remove this doc since it no longer applies. And we have in the migration guide to cover that plugins are not supported anymore.

@jc-berger
Copy link
Contributor Author

jc-berger commented Apr 7, 2021

Closing this PR and making a new one to remove the plugin doc as recommended. See the new PR for the work to remove the doc instead of edit it: #49

@jc-berger jc-berger closed this Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress documentation Improvements or additions to documentation needs-rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants